Script to regenerate test fixtures, upgrade to Pyre 0.9.10#872
Merged
amyreese merged 1 commit intoInstagram:mainfrom Feb 22, 2023
Merged
Script to regenerate test fixtures, upgrade to Pyre 0.9.10#872amyreese merged 1 commit intoInstagram:mainfrom
amyreese merged 1 commit intoInstagram:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 94.79% 94.87% +0.07%
==========================================
Files 249 249
Lines 25831 25813 -18
==========================================
+ Hits 24487 24489 +2
+ Misses 1344 1324 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Sigh, apparently this functionality already exists in the undocumented |
1de82cc to
5e7efdd
Compare
Contributor
Author
|
Removed old script from test stub, updated CI config, and cleaned up lint. |
Upgrading Pyre requires updating test fixtures with any upstream changes to Pyre's query results for the `simple_class.py` fixture. This adds a new `scripts/` directory to the repo, with a script to regenerate test fixtures. The script regenerates the cache data fixture, and updates the `TypeInferenceProvider` tests to use `assertDictEqual` and helpful error messages for better behavior in future mismatches. This also includes a slight bump to Pyre 0.9.10 to fix install issues on Apple Silicon M1 Macs, and regenerated fixtures using the script above.
zsol
approved these changes
Feb 22, 2023
Contributor
zsol
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the old script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrading Pyre requires updating test fixtures with any upstream changes
to Pyre's query results for the
simple_class.pyfixture.This adds a new
scripts/directory to the repo, with a script toregenerate test fixtures. The script regenerates the cache data fixture,
and updates the
TypeInferenceProvidertests to useassertDictEqualand helpful error messages for better behavior in future mismatches.
This also includes a slight bump to Pyre 0.9.10 to fix install issues on
Apple Silicon M1 Macs, and regenerated fixtures using the script above.
Test Plan
python -m unittest -vk test_type_inference_provider