Issue #85 - fixes for CoreSizeLimitHandler#86
Merged
copybara-service[bot] merged 2 commits intomainfrom Dec 15, 2023
Merged
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Collaborator
Author
|
Please also wait for a review from @gregw before merging. I will also open a PR to test and fix this in Jetty, and once that is released we can use the Jetty version of this handler. |
Collaborator
|
Should we still wait? |
Collaborator
Author
|
@ludoch this was approved in jetty/jetty.project#11051, with some remaining changes requested for the javadoc. So I'd say we're good to merge here. I have tested this manually by deploying to prod, and I have added an additional test in the Jetty PR for this. But would be good to add tests here as well. |
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
PiperOrigin-RevId: 591117937 Change-Id: I903eb5ac1f2d28ac4c093331d367d94e8907dad5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #85
CoreSizeLimitHandlerwas not resetting its read/written counts for each request.While testing this fix I also discovered that because it is using an
HttpStream.Wrapperit is bypassing theGzipHandler, so I have changed this to also wrap theRequestandResponseinstead of relying on wrapping the stream.Note this
CoreSizeLimitHandleris only used for Jetty 12 code, the Jetty 9 one does not have these issues.