Fixes for AppEngineAuthentication in EE10#76
Merged
copybara-service[bot] merged 3 commits intomainfrom Nov 8, 2023
Merged
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…ication PiperOrigin-RevId: 580551860 Change-Id: I5917bddb7cfa2af0a89ee868350cbd8273dcd754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the
JavaRuntimeAllInOneTestfor EE10Returning null from
validateRequest()to get deferred authentication is not the right thing to do because it only works if authentication is not mandatory.We should instead override
ConstraintSecurityHandler.getConstraintandAuthenticator.getConstraintAuthenticationto allow the request bypass the authentication constraints.