Lock third-party actions#118
Merged
cole-h merged 1 commit intoDeterminateSystems:mainfrom Jun 18, 2024
Merged
Conversation
A caller of this action can lock this action to a specific commit. However because the action itself does not lock its dependent actions to a specific commit this opens the end-user up to possible supply-chain attacks if the dependent actions rewrite their tags. This PR changes all third party actions to be explicitly locked. Dependabot will still work and update these hashes for you I also suggest installing https://github.com/ossf/scorecard in this repo. It will report about these kind of issues. Note that you should in turn have to audit all the third party deps of the actions that your action depends on. In general this is all a bit of a mess and GitHub's security model is very meh e.g. see ossf/scorecard#2189
cole-h
approved these changes
Jun 18, 2024
Member
cole-h
left a comment
There was a problem hiding this comment.
Thanks! I didn't know dependabot would be fine updating these hashes.
I'll look into integrating the scorecard separately.
dc-tec
referenced
this pull request
in dc-tec/nixvim
Aug 7, 2024
#19) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [DeterminateSystems/update-flake-lock](https://togithub.com/DeterminateSystems/update-flake-lock) | action | major | `v22` -> `v23` | --- ### Release Notes <details> <summary>DeterminateSystems/update-flake-lock (DeterminateSystems/update-flake-lock)</summary> ### [`v23`](https://togithub.com/DeterminateSystems/update-flake-lock/releases/tag/v23) [Compare Source](https://togithub.com/DeterminateSystems/update-flake-lock/compare/v22...v23) #### What's Changed - Lock third-party actions by [@​arianvp](https://togithub.com/arianvp) in [https://github.com/DeterminateSystems/update-flake-lock/pull/118](https://togithub.com/DeterminateSystems/update-flake-lock/pull/118) - Add instructions for new fine grained GitHub PAT by [@​ibizaman](https://togithub.com/ibizaman) in [https://github.com/DeterminateSystems/update-flake-lock/pull/92](https://togithub.com/DeterminateSystems/update-flake-lock/pull/92) - Fixup support for Nix 2.23.0 and later by [@​cole-h](https://togithub.com/cole-h) in [https://github.com/DeterminateSystems/update-flake-lock/pull/121](https://togithub.com/DeterminateSystems/update-flake-lock/pull/121) #### New Contributors - [@​arianvp](https://togithub.com/arianvp) made their first contribution in [https://github.com/DeterminateSystems/update-flake-lock/pull/118](https://togithub.com/DeterminateSystems/update-flake-lock/pull/118) - [@​ibizaman](https://togithub.com/ibizaman) made their first contribution in [https://github.com/DeterminateSystems/update-flake-lock/pull/92](https://togithub.com/DeterminateSystems/update-flake-lock/pull/92) **Full Changelog**: DeterminateSystems/update-flake-lock@v22...v23 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dc-tec/nixvim). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A caller of this action can lock this action to a specific commit. However because the action itself does not lock its dependent actions to a specific commit this opens the end-user up to possible supply-chain attacks if the dependent actions rewrite their tags.
This PR changes all third party actions to be explicitly locked.
Dependabot will still work and update these hashes for you
I also suggest installing https://github.com/ossf/scorecard in this repo. It will report about these kind of issues.
Note that you should in turn have to audit all the third party deps of the actions that your action depends on. In general this is all a bit of a mess and GitHub's security model is very meh
e.g. see ossf/scorecard#2189
Checklist