add rule for detecting script bindings#738
Merged
Merged
Conversation
chrismair
reviewed
Jul 22, 2023
chrismair
left a comment
Contributor
There was a problem hiding this comment.
Please also add some markdown doc for this rule in "docs/codenarc-rules-concurrency.md""
Contributor
Author
|
Thanks for the quick review. Tests are passing, and I think I addressed all the feedback. |
chrismair
approved these changes
Jul 22, 2023
Contributor
|
Thanks for the contribution! |
chrismair
added a commit
that referenced
this pull request
Jul 30, 2023
add rule for detecting script bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at #469
I added some tests. Haven't worked much with groovy or codenarc so hopefully it's alright.