Allow overriding Git configuration when cloning.

bittrance · bittrance · commit 9833b45c59eb · 2023-12-08T10:45:58.000+01:00
diff --git a/gix/src/clone/access.rs b/gix/src/clone/access.rs
@@ -34,6 +34,13 @@ impl PrepareFetch {
         self.shallow = shallow;
         self
     }
+
+    /// Apply the given configuration `values` early to allow affecting the repository instantiation phase.
+    /// The configuration is marked with [source API][gix_config::Source::Api].
+    pub fn config_overrides(mut self, values: impl IntoIterator<Item = impl Into<BString>>) -> Self {
+        self.api_config_overrides = values.into_iter().map(Into::into).collect();
+        self
+    }
 }
 
 /// Consumption
diff --git a/gix/src/clone/fetch/mod.rs b/gix/src/clone/fetch/mod.rs
@@ -18,6 +18,10 @@ pub enum Error {
     RemoteConnection(#[source] Box<dyn std::error::Error + Send + Sync>),
     #[error(transparent)]
     RemoteName(#[from] crate::config::remote::symbolic_name::Error),
+    #[error(transparent)]
+    ParseConfig(#[from] crate::config::overrides::Error),
+    #[error(transparent)]
+    ApplyConfig(#[from] crate::config::Error),
     #[error("Failed to load repo-local git configuration before writing")]
     LoadConfig(#[from] gix_config::file::init::from_paths::Error),
     #[error("Failed to store configured remote in memory")]
@@ -75,6 +79,10 @@ impl PrepareFetch {
             .as_mut()
             .expect("user error: multiple calls are allowed only until it succeeds");
 
+        let mut snapshot = repo.config_snapshot_mut();
+        snapshot.append_config(self.api_config_overrides.as_slice(), gix_config::Source::Api)?;
+        snapshot.commit()?;
+
         let remote_name = match self.remote_name.as_ref() {
             Some(name) => name.to_owned(),
             None => repo
diff --git a/gix/src/clone/mod.rs b/gix/src/clone/mod.rs
@@ -20,6 +20,8 @@ pub struct PrepareFetch {
     repo: Option<crate::Repository>,
     /// The name of the remote, which defaults to `origin` if not overridden.
     remote_name: Option<BString>,
+    /// Additional config `values` that are applied in-memory before starting the fetch process.
+    api_config_overrides: Vec<BString>,
     /// A function to configure a remote prior to fetching a pack.
     configure_remote: Option<ConfigureRemoteFn>,
     /// A function to configure a connection before using it.
@@ -126,6 +128,7 @@ impl PrepareFetch {
             #[cfg(any(feature = "async-network-client", feature = "blocking-network-client"))]
             fetch_options: Default::default(),
             repo: Some(repo),
+            api_config_overrides: Vec::new(),
             remote_name: None,
             configure_remote: None,
             #[cfg(any(feature = "async-network-client", feature = "blocking-network-client"))]

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,13 @@ impl PrepareFetch {`
`34`	`34`	`self.shallow = shallow;`
`35`	`35`	`self`
`36`	`36`	`}`
	`37`	`+`
	`38`	+ /// Apply the given configuration `values` early to allow affecting the repository instantiation phase.
	`39`	`+ /// The configuration is marked with [source API][gix_config::Source::Api].`
	`40`	`+ pub fn config_overrides(mut self, values: impl IntoIterator<Item = impl Into<BString>>) -> Self {`
	`41`	`+ self.api_config_overrides = values.into_iter().map(Into::into).collect();`
	`42`	`+ self`
	`43`	`+ }`
`37`	`44`	`}`
`38`	`45`
`39`	`46`	`/// Consumption`