thanks clippy

Byron · Byron · commit 113cbcc3028e · 2024-07-22T22:10:16.000+02:00
diff --git a/gix-attributes/src/state.rs b/gix-attributes/src/state.rs
@@ -37,7 +37,7 @@ impl ValueRef<'_> {
 
 impl<'a> From<&'a str> for ValueRef<'a> {
     fn from(v: &'a str) -> Self {
-        ValueRef(v.as_bytes().into())
+        ValueRef(v.as_bytes())
     }
 }
 
diff --git a/gix-transport/src/client/git/mod.rs b/gix-transport/src/client/git/mod.rs
@@ -64,7 +64,7 @@ mod message {
             out.extend_from_slice(host.as_bytes());
             if let Some(port) = port {
                 out.push_byte(b':');
-                out.push_str(&format!("{port}"));
+                out.push_str(format!("{port}"));
             }
             out.push(0);
         }
diff --git a/gix/src/repository/config/transport.rs b/gix/src/repository/config/transport.rs
@@ -193,10 +193,7 @@ impl crate::Repository {
                         remote_name
                             .and_then(|name| {
                                 config
-                                    .string_filter(
-                                        &format!("remote.{}.{}", name, Remote::PROXY.name),
-                                        &mut trusted_only,
-                                    )
+                                    .string_filter(format!("remote.{}.{}", name, Remote::PROXY.name), &mut trusted_only)
                                     .map(|v| (v, Cow::Owned(format!("remote.{name}.proxy").into()), &Remote::PROXY))
                             })
                             .or_else(|| {
@@ -254,7 +251,7 @@ impl crate::Repository {
                                 remote_name
                                     .and_then(|name| {
                                         config
-                                            .string_filter(&format!("remote.{name}.proxyAuthMethod"), &mut trusted_only)
+                                            .string_filter(format!("remote.{name}.proxyAuthMethod"), &mut trusted_only)
                                             .map(|v| {
                                                 (
                                                     v,
diff --git a/gix/src/repository/remote.rs b/gix/src/repository/remote.rs
@@ -137,7 +137,7 @@ impl crate::Repository {
         let mut config_url = |key: &'static config::tree::keys::Url, kind: &'static str| {
             self.config
                 .resolved
-                .string_filter(&format!("remote.{}.{}", name_or_url, key.name), &mut filter)
+                .string_filter(format!("remote.{}.{}", name_or_url, key.name), &mut filter)
                 .map(|url| {
                     key.try_into_url(url).map_err(|err| find::Error::Url {
                         kind,
@@ -151,7 +151,7 @@ impl crate::Repository {
         let config = &self.config.resolved;
 
         let fetch_specs = config
-            .strings_filter(&format!("remote.{}.{}", name_or_url, "fetch"), &mut filter)
+            .strings_filter(format!("remote.{}.{}", name_or_url, "fetch"), &mut filter)
             .map(|specs| {
                 config_spec(
                     specs,
@@ -161,7 +161,7 @@ impl crate::Repository {
                 )
             });
         let push_specs = config
-            .strings_filter(&format!("remote.{}.{}", name_or_url, "push"), &mut filter)
+            .strings_filter(format!("remote.{}.{}", name_or_url, "push"), &mut filter)
             .map(|specs| {
                 config_spec(
                     specs,
@@ -171,7 +171,7 @@ impl crate::Repository {
                 )
             });
         let fetch_tags = config
-            .string_filter(&format!("remote.{}.{}", name_or_url, "tagOpt"), &mut filter)
+            .string_filter(format!("remote.{}.{}", name_or_url, "tagOpt"), &mut filter)
             .map(|value| {
                 config::tree::Remote::TAG_OPT
                     .try_into_tag_opt(value)

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ impl ValueRef<'_> {`
`37`	`37`
`38`	`38`	`impl<'a> From<&'a str> for ValueRef<'a> {`
`39`	`39`	`fn from(v: &'a str) -> Self {`
`40`		`- ValueRef(v.as_bytes().into())`
	`40`	`+ ValueRef(v.as_bytes())`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ mod message {`
`64`	`64`	`out.extend_from_slice(host.as_bytes());`
`65`	`65`	`if let Some(port) = port {`
`66`	`66`	`out.push_byte(b':');`
`67`		`- out.push_str(&format!("{port}"));`
	`67`	`+ out.push_str(format!("{port}"));`
`68`	`68`	`}`
`69`	`69`	`out.push(0);`
`70`	`70`	`}`