fix(grep, sed, sort, uniq): Split only on newline characters#690
fix(grep, sed, sort, uniq): Split only on newline characters#690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
- Coverage 94.67% 94.67% -0.01%
==========================================
Files 33 33
Lines 1183 1182 -1
==========================================
- Hits 1120 1119 -1
Misses 63 63
Continue to review full report at Codecov.
|
|
@freitagbr can you see what the issue is with code coverage? If we're uncovering any lines, we should see if we can add tests. |
|
The diff is +7/-9, so overall -2, so the coverage is going to decrease. No lines are becoming uncovered. |
nfischer
left a comment
There was a problem hiding this comment.
LGTM, but should we consider this a breaking change? We didn't need to change any tests, but this change would be visible to users operating on CRLF files.
|
I think it could be breaking. Just to be safe, let's change the target branch to dev so this can land in v0.8. |
36e7e66 to
4caabf1
Compare
* Split on newlines only * Only split lines if need be * Clarify code by making use of Array.prototype.reduce
* Split on newlines only * Only split lines if need be * Clarify code by making use of Array.prototype.reduce
Splits and joins on newlines only.
Fixes #645 .