HIVE-8411: Support partial partition spec for certain ALTER PARTITION statements
Review Request #26481 - Created Oct. 9, 2014 and updated
| Information | |
|---|---|
| Jason Dere | |
| hive-git | |
| HIVE-8411 | |
| Reviewers | |
| hive | |
| haglein, thejas | |
Allow partial partition spec for some alter table statements, such as:
alter table alter_partition_change_col1 partition (p1) change column c2 c2 decimal(10,0);
updated qfile test
Issues
- 5
- 0
- 0
- 5
| Description | From | Last Updated |
|---|---|---|
| there's a flag for enabling dynamic partitioning. is this checked somewhere in this path? ppl use that to avoid someone ... |
Gunther Hagleitner
|
|
| why does this fail? it seems more consistent to just alter 0 partitions in this case. or at least just ... |
Gunther Hagleitner
|
|
| LOG.error? |
Gunther Hagleitner
|
|
| does this support multi level partitioning? if so can you specify only some of the partitions? |
Gunther Hagleitner
|
|
| add a query to verify the output? |
Gunther Hagleitner
|
-
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (Diff revision 1) -
there's a flag for enabling dynamic partitioning. is this checked somewhere in this path? ppl use that to avoid someone accidentally changing everything.
-
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (Diff revision 1) -
why does this fail? it seems more consistent to just alter 0 partitions in this case. or at least just print a warning instead of failing.
-
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (Diff revision 1) -
LOG.error?
-
ql/src/test/queries/clientpositive/alter_partition_change_col.q (Diff revision 1) -
does this support multi level partitioning? if so can you specify only some of the partitions?
-
ql/src/test/queries/clientpositive/alter_partition_change_col.q (Diff revision 1) -
add a query to verify the output?
Change Summary:
changes based on review feedback:
- Added check if dynamic partitioning is enabled
- Only fail for 0 partitions if fully specified partition spec
- Changed alter_partition_change_col.q to have multiple partition columns
- added negative test to test when dynamic partitioning disabled