HIVE-6246: Sign(a) UDF is not supported for decimal type

Reviews
Diff

- Download Diff

Information
Submitter:	Xuefu Zhang
Repository:	hive-git
Branch:	trunk
Bugs:	HIVE-6246
Depends On:
Reviewers
Groups:	hive
People:

Description

Please see the JIRA description. It's believed that this has nevered worked. Added a method in UDFSign class to handle Decimal data type to make it work. This method returns INT instead of doulbe to be inline with other data bases.

Testing Done

Unit test is added.

Overall looks good.
Is it possible to add a .q test or append to an existing .q test?

Xuefu Zhang Jan. 24, 2014, 3:02 p.m.

Actually unit test such as that provided is preferrable. Additional .q test only prelongs the build process while not providing much value for this case.

Mohammad Islam Jan. 27, 2014, 7:49 p.m.

ok with me. I agree the build-timing is important. but, in some instances,i found people prefer .q test.

ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSign.java (Diff revision 1)

Minor issue: does testByte() is a good name?

Xuefu Zhang Jan. 24, 2014, 3:02 p.m.
```
A result of C&P. Will change it.
```
Mohammad Islam Jan. 27, 2014, 7:49 p.m.
```
sounds good.
```

ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java (Diff revision 1)

Nit: Add Javadoc.

ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java (Diff revision 1)

Nit: Add javadoc to this new method.

Ship it!

LGTM

common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java (Diff revision 1)

Nit: ws

You have a pending review.

Review Board 2.5.9

Screenshots

Files