Ignore empty fixture directories and fix fixtures in the parser#9113
Merged
danez merged 3 commits intobabel:masterfrom Dec 3, 2018
danez:fix-empt-fixture-dirs
Merged
Ignore empty fixture directories and fix fixtures in the parser#9113danez merged 3 commits intobabel:masterfrom danez:fix-empt-fixture-dirs
danez merged 3 commits intobabel:masterfrom
danez:fix-empt-fixture-dirs
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9516/ |
nicolo-ribaudo
approved these changes
Dec 2, 2018
This was referenced Dec 4, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay this PR started because I was annoyed that sometimes when I added fixtures somewhere but then ended up reverting, the empty folder was keep but the fixture runner was still generating an
output.js.So I went in and changed the behavior of the fixture runner to ignore folders if there is neither
input.extnorexec.js. This is the first commit.I checked which folders are ignored and noticed that there are some test fixtures in babylon which are never executed because the folder structure was wrong or the files were named incorrectly.
I fixed all of these cases which are in the second commit.
I noticed another potential issue with regular expressions where we do not check if character ranges are valid, but I did not want to dive into this one yet. So the tests for this are currently skipped.
I removed the other change and moved it into a PR #9114