Remove unused variable#9089
Merged
danez merged 1 commit intobabel:masterfrom Nov 27, 2018
Merged
Conversation
When I was reading the code, I see `parent` is not used in `_getComments` function. so it make me confused why we delivery the `parent` in those functions. If I'm wrong, please correct me.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9467/ |
danez
approved these changes
Nov 27, 2018
Member
danez
left a comment
There was a problem hiding this comment.
Nice catch. Thank you very much.
This was referenced Dec 4, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was reading the code, I see
parentis not used in_getCommentsfunction.so it make me confused why we delivery the
parentin those functions.If I'm wrong, please correct me.