feat: Add jiff integration#323
Conversation
| deflate-zlib = ["flate2/zlib", "deflate-flate2"] | ||
| deflate-zlib-ng = ["flate2/zlib-ng", "deflate-flate2"] | ||
| deflate-zopfli = ["zopfli", "_deflate-any"] | ||
| jiff = ["dep:jiff"] |
There was a problem hiding this comment.
I would strongly encourage using jiff-02 here like what rust-postgres does: https://github.com/sfackler/rust-postgres/blob/490c4852492bb0adf63a83e3c4e8b2afc9e6bf54/postgres-types/Cargo.toml#L54
There was a problem hiding this comment.
Is the reason for using jiff-02 because jiff's API is not yet stable?
There was a problem hiding this comment.
I'm not sure I would phrase it that way, but probably yes. If you just called it jiff, what would you do when jiff 1.0 comes out? Bumping it would be a semver breaking change.
Technically the same is true for chrono and time. I don't believe either have an official policy on when to do semver incompatible releases. But so many people depend on them that such releases would be a huge headache.
Which is why, as documents in Jiff's README, I'm planning to release jiff 1.0 this summer and commit to it indefinitely.
Add
jifffeature to this crate.This enables converting last-modified
zip::DateTimeto and fromjiff::civil::DateTimewhen this feature is enabled, similar to how converting last-modifiedzip::DateTimeto and fromchrono::NaiveDateTimewhen thechronofeature is enabled.