feat: Add legacy shrink/reduce/implode compression#303
feat: Add legacy shrink/reduce/implode compression#303Pr0methean merged 21 commits intozip-rs:masterfrom
Conversation
Pr0methean
left a comment
There was a problem hiding this comment.
Mostly looks good; just some nitpicks.
|
ty |
Head branch was pushed to by a user without write access
eaeccf6 to
09ff06b
Compare
|
Updated to bitstream-io 2.6.0 + upped rust version. |
Pr0methean
left a comment
There was a problem hiding this comment.
Looking good, but still a fair number of nitpicks.
Pr0methean
left a comment
There was a problem hiding this comment.
See my previous review; GitHub didn't think it was finished for some reason.
abba2b8 to
cceb58f
Compare
|
I really need to work more often on my bbs project but had too much work to do elsewhere the last few months :/ |
46efb7d to
5e06ecc
Compare
|
rebased with master, upped bitstream-io. Rust is a fast moving target :). |
7189839 to
17e647c
Compare
e0872d8 to
6e5e853
Compare
6e5e853 to
1ca1d67
Compare
53a0649 to
5b49a81
Compare
8f159a1 to
7e9578b
Compare
|
@mkrueger Could you please fix the test failures on Windows caused by newline styles? I've tried every way I can think of and nothing's working; and since you checked in the files with Windows-style newlines, I'm guessing you use a Windows machine for development and thus have much more experience with this kind of issue than I do -- or at least, that you can reproduce it locally. If nothing else works, you can always change the test data so that it doesn't contain any newlines. |
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
b6bc474 to
e9207c5
Compare
* Added legacy shrink/reduce/implode compression. * Remove the unused 0th len_count entry Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> * Make legacy modules `pub(crate)` rather than `pub` Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> * chore(deps): Bump MSRV to 1.83.0 for bistream-io * style: cargo fmt --all * style: cargo clippy --fix * chore: fix remaining Clippy warnings manually * style: cargo fmt --all * fix: errors introduced by fixing clippy warnings * fix: test failures on Windows due to newline style * fix: must define legacy compression methods unconditionally, for backward compatibility * style: Add missing doc comments * fix: doc comments apparently can't be before `cfg` * fix: doc comments apparently can't be before `cfg` * fix: Windows newline issues persisted (files not recognized as text?) * fix: Windows newline issues persisted (need to mark some files text and others binary) * fix?! Test a peer's suggested fix * fix use lf instead of crlf to fix tests on windows * Fix? make tests/data/legacy/*.out explicitly CRLF --------- Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Co-authored-by: hennickc <hennickc@amazon.com> Co-authored-by: Speedy_Lex <78314533+speedy-lex@users.noreply.github.com>
|
yeah ! :) ty - took a long time but I need that for one of my open source projects that are really… let's say special. An old school bbs system re creating one of the most well known systems from the 80' https://github.com/mkrueger/icy_board/ :) |
Replaces #120
The original PR grew too large to sanely merge it - ported it manually to zip-rs HEAD and reopened the PR.
I need the legacy formats for my BBS project which I've not touched for some while but I've continued on that lately.