fix: return correct offset in SeekableTake::seek#342
Merged
Conversation
SeekableTake has a window to an inner Reader. It should return the offset relative to this window, and not the absolute offset relative to the entire reader. Signed-off-by: Cfir Cohen <cfir@wiz.io>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
This was referenced May 14, 2025
Closed
Closed
Merged
cosmicexplorer
pushed a commit
to cosmicexplorer/zip2
that referenced
this pull request
Sep 30, 2025
* fix: return correct offset in SeekableTake::seek SeekableTake has a window to an inner Reader. It should return the offset relative to this window, and not the absolute offset relative to the entire reader. Signed-off-by: Cfir Cohen <cfir@wiz.io> * chore!: Drop deprecated `deflate-miniz` feature flag * chore: Temporarily add back deflate-miniz Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> * chore: Temporarily add back proc-macro2 dep --------- Signed-off-by: Cfir Cohen <cfir@wiz.io> Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Co-authored-by: hennickc <hennickc@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeekableTake has a window to an inner Reader.
It should return the offset relative to this window, and not the absolute offset relative to the entire reader.