Make shuffle pyx functions noexcept#477
Merged
jakirkham merged 6 commits intozarr-developers:mainfrom Oct 17, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
===========================================
+ Coverage 99.95% 100.00% +0.04%
===========================================
Files 56 56
Lines 2241 2242 +1
===========================================
+ Hits 2240 2242 +2
+ Misses 1 0 -1 |
jakirkham
reviewed
Oct 16, 2023
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Martin! 🙏
IIUC adding noexcept should be sufficient here (looking at this Cython doc section)
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
noexcept
Member
|
Thanks Martin! 🙏 |
jakirkham
approved these changes
Oct 17, 2023
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/numcodecs
that referenced
this pull request
Aug 10, 2024
* Make shuffle pyx functions return int * Update numcodecs/_shuffle.pyx Co-authored-by: jakirkham <jakirkham@gmail.com> * Update numcodecs/_shuffle.pyx Co-authored-by: jakirkham <jakirkham@gmail.com> * Note shuffle pyx functions are `noexcept` --------- Co-authored-by: jakirkham <jakirkham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476
@jakirkham , like this? The functions don't actually return anything.
Do we have any process to determine which codecs release the GIL? Given the performance discussions, this could be imporant.