Skip to content

fix: allow absolute file paths on create#3518

Merged
AustinAbro321 merged 8 commits intomainfrom
fix-absolute-file-paths
Feb 21, 2025
Merged

fix: allow absolute file paths on create#3518
AustinAbro321 merged 8 commits intomainfrom
fix-absolute-file-paths

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

@AustinAbro321 AustinAbro321 commented Feb 19, 2025

Related Issue

Fixes #3475

Checklist before merging

@AustinAbro321
fix absolute file paths
1fa2259 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners February 19, 2025 20:43
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit dd5c1ce
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67b794cc247cf30008af9c35

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/create.go 12.50% 6 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/import.go 44.69% <100.00%> (+1.87%) ⬆️
src/internal/packager2/layout/create.go 40.14% <12.50%> (+6.07%) ⬆️

... and 4 files with indirect coverage changes

@AustinAbro321
test file paths
07dec2a 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
improve tests
7ea8982 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
Merge branch 'main' into fix-absolute-file-paths
8ed5ea9
@AustinAbro321
cleanup test
475a2b8 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
absolute path file source
876aa18 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
test updates
f2ca2c3 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
Copy link
Copy Markdown
Member Author

AustinAbro321 commented Feb 20, 2025

Moving back into draft, tests not doing what I would expect

@AustinAbro321 AustinAbro321 marked this pull request as draft February 20, 2025 16:50
@AustinAbro321
format
dd5c1ce 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
Copy link
Copy Markdown
Member Author

AustinAbro321 commented Feb 20, 2025

Okay should be good now

@AustinAbro321 AustinAbro321 marked this pull request as ready for review February 20, 2025 20:47
brandtkeller
brandtkeller approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ran a test of main and this branch using the issue example in order to step through the changes - saw the expected outcomes of failure on main and successful execution with these changes

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 88b5842 Feb 21, 2025
@AustinAbro321 AustinAbro321 deleted the fix-absolute-file-paths branch February 21, 2025 14:43
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
@AustinAbro321 @nevinaragam
fix: allow absolute file paths on create (zarf-dev#3518)
016858c 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zarf errors when absolute file paths are used in components.files.source

2 participants

@AustinAbro321 @brandtkeller