Skip to content

fix: pass insecure flag option to FindChartInAuthAndTLSRepoURL#3477

Merged
AustinAbro321 merged 1 commit intozarf-dev:mainfrom
willswire:patch-1
Feb 7, 2025
Merged

fix: pass insecure flag option to FindChartInAuthAndTLSRepoURL#3477
AustinAbro321 merged 1 commit intozarf-dev:mainfrom
willswire:patch-1

Conversation

@willswire
Copy link
Contributor

@willswire willswire commented Feb 7, 2025

Description

Rather than use FindChartInAuthRepoURL, we can instead use FindChartInAuthAndTLSRepoURL and pass the Zarf CLI --insecure-skip-tls-verify boolean flag down directly via config.CommonOptions.InsecureSkipTLSVerify.

Related Issue

Fixes #3476

Checklist before merging

@willswire willswire requested review from a team as code owners February 7, 2025 04:14
@netlify
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d8cf285
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67a589cc4c17f7000899508a

Signed-off-by: William Walker <w_walker@icloud.com>
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/helm/repo.go 0.00% 12 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/helm/repo.go 24.83% <0.00%> (-0.94%) ⬇️

Copy link
Member

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into zarf-dev:main with commit 6cf9954 Feb 7, 2025
26 checks passed
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
…dev#3477)

Signed-off-by: William Walker <w_walker@icloud.com>
Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting --insecure-skip-tls-verify does not work for Helm chart components using repos

2 participants