test: delete e2e test for examples/package-flavors#3463
Merged
AustinAbro321 merged 1 commit intomainfrom Feb 5, 2025
Merged
Conversation
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
mkcp
approved these changes
Feb 5, 2025
Contributor
mkcp
left a comment
There was a problem hiding this comment.
Always good to have a lean test suite 👍
1 task
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This deletes the e2e test for package flavors. The other test in 10_component_flavor_test.go already covers flavors and
layout2.LoadFromTarmore in depth. We have unit tests for verifying package builds with flavors as well.I think the package-flavors example does a good job of showing off the
--flavorfeature, but doesn't make for a good e2e test. Especially since it pulls images from dockerhub which can lead to flakes on TOOMANYREQUESTS.Checklist before merging