fix: log correct size with units during image pull#3440
Merged
AustinAbro321 merged 2 commits intomainfrom Jan 27, 2025
Merged
Conversation
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
mkcp
previously approved these changes
Jan 27, 2025
| return eg.Wait() | ||
| } | ||
|
|
||
| func getSizeOfImage(img v1.Image) (int64, error) { |
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
mkcp
approved these changes
Jan 27, 2025
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3439
Checklist before merging