Fix for wrong connection count on remote nodes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneeraj
approved these changes
Jan 24, 2024
ashetkar
reviewed
Jan 24, 2024
.../com/yugabyte/oss/driver/internal/core/loadbalancing/YugabyteDefaultLoadBalancingPolicy.java
Outdated
Show resolved
Hide resolved
|
Also, please run the formatting command and commit the changes |
kneeraj
suggested changes
Jan 24, 2024
kneeraj
left a comment
There was a problem hiding this comment.
Should get a clean run of nosqlbench with correct routing behaviour before merging.
Author
|
@HarshDaryani896 Let's get this PR cleaned of all the debugging logs and merge it, if we have successfully completed all the testing. |
ashetkar
reviewed
Feb 6, 2024
ashetkar
left a comment
There was a problem hiding this comment.
Also, please add a log at debug/info 1) when metadata is refreshed and 2) when leader is not found for a particular tablet.
.../src/main/java/com/yugabyte/oss/driver/internal/core/loadbalancing/PartitionAwarePolicy.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/yugabyte/oss/driver/internal/core/loadbalancing/PartitionAwarePolicy.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/yugabyte/oss/driver/internal/core/loadbalancing/PartitionAwarePolicy.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:Even after settingCONNECTION_POOL_REMOTE_SIZEto zero, connections were getting created to remote nodes. Number of connections on REMOTE nodes were equal to Number of connections on LOCAL nodes.On some investigation we found out that the private localDc variable of
YugabyteDefaultLoadBalancingPolicyclass [child class] was hiding the localDc variable of theBasicLoadBalancingPolicyclass [parent class], due to which the driver was not properly identifying Local AND Remote nodes. It was considering all Up nodes as Local.Fix
Removed the private localDc from
YugabyteDefaultLoadBalancingPolicyand made the localDc variable inBasicLoadBalancingPolicyprotected.Also did this change for another private member variable of
YugabyteDefaultLoadBalancingPolicyclass:distanceReporterNote
This PR also includes some formatting changes in PartitionAwarePolicy.java
Testing
TestDMLRoutingLocality(these occur with 4.15.0-yb-1 also).