Unskip runc tests after CI runc update 1.3.1#3249
Merged
YJDoc2 merged 1 commit intoyouki-dev:mainfrom Sep 24, 2025
Merged
Conversation
Signed-off-by: Yusuke Sakurai <yusuke.sakurai@3-shake.com>
YJDoc2
approved these changes
Sep 24, 2025
Collaborator
YJDoc2
left a comment
There was a problem hiding this comment.
lgtm, as all tests are passing, and changes are only related to test, merging.
Merged
sat0ken
pushed a commit
to sat0ken/youki
that referenced
this pull request
Mar 17, 2026
Unskip runc tests after CI runc update 1.3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following tests had been skipped because the runc version used in CI was
1.1.11.The runc version was updated in the commit below.
#3237
Therefore, I am removing the
is_runtime_runchandling from the tests that now pass:(Since the
fd_controltests still appear to fail on runc, we’ll keep them as-is for now.)Type of Change
Testing
Related Issues
Fixes #3141
Additional Context
The referenced issue concerns the failure of the
rootfs_propagationtest. It will be resolved once this PR is merged.