Skip to content

Unskip runc tests after CI runc update 1.3.1#3249

Merged
YJDoc2 merged 1 commit intoyouki-dev:mainfrom
saku3:udpate-test-for-runc
Sep 24, 2025
Merged

Unskip runc tests after CI runc update 1.3.1#3249
YJDoc2 merged 1 commit intoyouki-dev:mainfrom
saku3:udpate-test-for-runc

Conversation

@saku3
Copy link
Copy Markdown
Member

@saku3 saku3 commented Sep 20, 2025

Description

The following tests had been skipped because the runc version used in CI was 1.1.11.
The runc version was updated in the commit below.
#3237

Therefore, I am removing the is_runtime_runc handling from the tests that now pass:

  • domainname
  • exec_cpu_affinity
  • io_priority
  • process_user
  • rootfs_propagation
  • scheduler_policy

(Since the fd_control tests still appear to fail on runc, we’ll keep them as-is for now.)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #3141

Additional Context

The referenced issue concerns the failure of the rootfs_propagation test. It will be resolved once this PR is merged.

Signed-off-by: Yusuke Sakurai <yusuke.sakurai@3-shake.com>
Copy link
Copy Markdown
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as all tests are passing, and changes are only related to test, merging.

@YJDoc2 YJDoc2 merged commit cd4a245 into youki-dev:main Sep 24, 2025
30 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
sat0ken pushed a commit to sat0ken/youki that referenced this pull request Mar 17, 2026
Unskip runc tests after CI runc update 1.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed linux_rootfs_propagation integration test on runc

2 participants