Skip to content

Pin Cython build constraint to < 3.0#702

Merged
nitzmahone merged 1 commit intoyaml:release/6.0from
nitzmahone:cython_build_constraint
Jul 17, 2023
Merged

Pin Cython build constraint to < 3.0#702
nitzmahone merged 1 commit intoyaml:release/6.0from
nitzmahone:cython_build_constraint

Conversation

@nitzmahone
Copy link
Member

@nitzmahone nitzmahone commented Mar 3, 2023

Temporary workaround for #601.

This is just a stopgap measure to ensure the libyaml extension build continues to function whenever Cython 3.0 is released (date TBD). We'll want to prioritize the extension build rewrite to ensure that PyYAML can support Python > 3.11, as I'd be amazed if they backport things to the Cython 0.x branch once 3.0 has released.

We should discuss if we want to just release this as 6.0.post1 or what, since there are no code changes to the actual library, just build/packaging metadata...

@nitzmahone nitzmahone changed the base branch from release/6.0 to master March 3, 2023 23:27
@keith
Copy link

keith commented Jul 17, 2023

Merging and releasing this would fix #601

@rahul-theorem
Copy link

Would it be possible to backport this fix to 5.x & release a hotfix as well? We're currently blocked on upgrading to pyyaml v6 (which we're hoping to resolve this week), but it'd be helpful for a few reasons to be able to pick this up in 5.4.2

@hssyoo
Copy link

hssyoo commented Jul 17, 2023

Hi @nitzmahone, the AWS CLI is also currently impacted by this (aws/aws-cli#8036). If we can get this PR merged and released as 6.0.1, it will resolve the issues faced by the AWS CLI and other impacted packages.

@DeanWay
Copy link

DeanWay commented Jul 17, 2023

This is just a stopgap measure to ensure the libyaml extension build continues to function whenever Cython 3.0 is released (date TBD).

Cython just released 3.0 so everything that has any kind of transitive dependency on PyYAML will now fail to install. This is now a necessary change.

@mharding-hpe
Copy link

This is causing a number of products in our organization to be unbuildable. Please consider this another plea for a quick merge and release of this now critical PR.

Copy link

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just what we all need from pyyaml

@enmatt
Copy link

enmatt commented Jul 17, 2023

We've also been wrestling with this dependency issue this morning during our builds.

Copy link

@cgoessling cgoessling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be urgently appreciated.

@addyess
Copy link

addyess commented Jul 17, 2023

@ingydotnet, @xitology, and @perlpunk thanks for your quick review on this

@nitzmahone
Copy link
Member Author

Yep, I'll be doing a 6.0.1 release imminently to cover this (grumblesmurf that I somehow missed the Cython 3.0 release was actually happening since they've been in beta for so long).

No commitment to a 5.x backport/release, but if I can easily resurrect all the necessary wheel builds for it, I might consider it.

@antoniogomezalvarado
Copy link

antoniogomezalvarado commented Jul 17, 2023

For anyone that needs a quick fix for this do the following instead of installing PyYAML directly

git clone https://github.com/yaml/pyyaml.git && \
cd pyyaml && \
git checkout release/5.4.1 && \
sed -i.bak 's/Cython/Cython<3.0/g' pyproject.toml && \
python setup.py sdist && \
pip install --pre dist/PyYAML-5.4.1.tar.gz 

simahawk added a commit to simahawk/odoo-project-tools that referenced this pull request Jul 26, 2023
simahawk added a commit to simahawk/odoo-project-tools that referenced this pull request Jul 26, 2023
simahawk added a commit to simahawk/odoo-project-tools that referenced this pull request Jul 26, 2023
marcospri added a commit to hypothesis/viahtml that referenced this pull request Jul 27, 2023
Fixes build due to yaml/pyyaml#702
aaxelb added a commit to aaxelb/osf.io that referenced this pull request Jul 28, 2023
@RamakrishnaHande
Copy link

For anyone that needs a quick fix for this do the following instead of installing PyYAML directly

git clone https://github.com/yaml/pyyaml.git && \
cd pyyaml && \
git checkout release/5.4.1 && \
sed -i.bak 's/Cython/Cython<3.0/g' pyproject.toml && \
python setup.py sdist && \
pip install --pre dist/PyYAML-5.4.1.tar.gz 

For this should we install cython before hand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.