let ByteBuffer read 4 bytes as int in single call #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@xerial any chance to review? |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Sep 11, 2024
### What changes were proposed in this pull request? This pr aims to upgrade snappy-java from 1.1.10.6 to 1.1.10.7. ### Why are the changes needed? The new version bring a small performance improvement reading crc32c values in SnappyFramedInputStream - xerial/snappy-java#594 The full release notes as follows: - https://github.com/xerial/snappy-java/releases/tag/v1.1.10.7 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #48076 from LuciferYang/SPARK-49599. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small performance improvement reading crc32c values in SnappyFramedInputStream by allowing the ByteBuffer to do the work. As these are direct ByteBuffer instances, this means only a single call across native boundary.