fix: add default conditions for moduleResolve as documented#32
Merged
wooorm merged 2 commits intowooorm:mainfrom Aug 29, 2025
JounQin:patch-1
Merged
fix: add default conditions for moduleResolve as documented#32wooorm merged 2 commits intowooorm:mainfrom JounQin:patch-1
conditions for moduleResolve as documented#32wooorm merged 2 commits intowooorm:mainfrom
JounQin:patch-1
Conversation
Signed-off-by: JounQin <admin@1stg.me>
Owner
|
Hey! Good to have tests to make sure something is actually fixed. I imagine that it does not need to be defaulted at the top, but that lower down, the And, build needs to pass. And: can you match the existing style of not using |
Contributor
Author
|
@wooorm Done. |
wooorm
approved these changes
Aug 29, 2025
Owner
|
Released in 4.2.0! Really appreciate in Joun! I hope you are doing well :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/wooorm/import-meta-resolve#moduleresolvespecifier-parent-conditions-preservesymlinks
related prettier/prettier-cli#77