Support async functions under patch decorator#135
Merged
wolever merged 1 commit intowolever:masterfrom Mar 2, 2023
Merged
Conversation
wolever
added a commit
that referenced
this pull request
Mar 2, 2023
Support async functions under patch decorator (updates to #135)
Owner
|
Hey! Thank you very much for this! I've got the test added and a couple more things fixed here: #151 And I'll be getting a CONTRIBUTING doc up shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports the
@patchdecorator with parametrized when used with async methodsIts a pretty simple fix, I also tried to add tests but failed since
If you do manage to make the tests work, this is a simple test I wrote
For what its worth, it did pass all of the tests with 3.6+ (apart from nose), and I tested it with several patches as well
P.s you really should add some contributing guide explaining how to set the project up, and how to test it :)