fix: validate entries in nox.config, too, using attrs#880
Merged
henryiii merged 1 commit intowntrblm:mainfrom Nov 12, 2024
Merged
fix: validate entries in nox.config, too, using attrs#880henryiii merged 1 commit intowntrblm:mainfrom
henryiii merged 1 commit intowntrblm:mainfrom
Conversation
DiddiLeija
reviewed
Oct 31, 2024
Collaborator
DiddiLeija
left a comment
There was a problem hiding this comment.
Looks like a very handy fix to me! However I'd like to see what other mantainers think of adding a dependency before giving the approval :)
1f63e2f to
35533bd
Compare
Collaborator
Author
|
It's been a couple of weeks without any complaints, and I'd like to build on this, so I think I'll merge unless there are any last objections! |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
35533bd to
8662eb5
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #871. It also reduces the need for #872, as I think it makes it harder or impossible to incorrectly set this via normal means.
Attrs is a well respected, zero dependency, small library by a CPython core dev, but it is an extra dependency. If we did adopt it, though, I would start moving over a few other things, which could improve our internal typing too.
Incomplete list for "NoxCmdOptions":