Fix a routing issue with unnormalized content collection slugs#3327
Merged
Fix a routing issue with unnormalized content collection slugs#3327
Conversation
🦋 Changeset detectedLatest commit: 1d5e1b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
size-limit report 📦
|
HiDeoo
approved these changes
Jul 18, 2025
Member
HiDeoo
left a comment
There was a problem hiding this comment.
Left a tiny suggestion to add a comment, up to you if you want to add it or not, but otherwise, looks great and makes sense (as much as it can considering the topic ^^) to me.
Great investigation and fix 👏
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Merged
gxxxr-111
pushed a commit
to gxxxr-111/starlight
that referenced
this pull request
Apr 9, 2026
…stro#3327) Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Astro.paramsand content collection entries for entries which have a filename with non-normalized composition.اللُّغَةُ-الْعَرَبِيَّةُ/الْآجُرُومِيَّةُ.mduses a mix of precomposed and decomposed diacritics. However, Astro’s router always normalizes URL parameters, which led to a mismatch between Starlight’s routes and Astro’s params, resulting in a 404 for a file with that name.N.B. The test changes in this PR look big because I wrapped existing tests in a
describe()block, but apart from that those haven’t actually changed. I just renamedcomponents.test.tstobasics.test.tsto match and reuse the basics fixture and avoid spinning up a new fixture just for this.