Fix extra space in fragment (#1064)

Trombach · ematipico · web-flow · commit 6b6a1346b087 · 2025-02-06T09:12:41.000Z
* fix: off by on error

* test: add test case for fragment with leading line break

* Create tiny-buses-hide.md

* Update .changeset/tiny-buses-hide.md

---------

Co-authored-by: Emanuele Stoppa &lt;my.burning@gmail.com&gt;
diff --git a/.changeset/tiny-buses-hide.md b/.changeset/tiny-buses-hide.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/compiler": patch
+---
+
+Fixes a bug caused by having an extra space in the fragment tag in the TSX output
diff --git a/internal/printer/print-to-tsx.go b/internal/printer/print-to-tsx.go
@@ -706,10 +706,7 @@ declare const Astro: Readonly<import('astro').AstroGlobal<%s, typeof %s`, propsI
 		}
 	}
 	if len(n.Attr) == 0 {
-		endLoc = n.Loc[0].Start + len(n.Data) - 1
-	}
-	if endLoc == -1 {
-		endLoc = 0
+		endLoc = n.Loc[0].Start + len(n.Data)
 	}
 	isSelfClosing := false
 	hasLeadingSpace := false
diff --git a/packages/compiler/test/tsx/basic.ts b/packages/compiler/test/tsx/basic.ts
@@ -259,4 +259,15 @@ export default function __AstroComponent_(_props: Record<string, any>): any {}\n
 	assert.snapshot(code, output, 'expected code to match snapshot');
 });
 
+test('fragment with leading linebreak', async () => {
+	const input = `
+<>Test123</>`;
+	const output = `${TSXPrefix}<Fragment>
+<>Test123</>
+</Fragment>
+export default function __AstroComponent_(_props: Record<string, any>): any {}\n`;
+	const { code } = await convertToTSX(input, { sourcemap: 'external' });
+	assert.snapshot(code, output, 'expected code to match snapshot');
+});
+
 test.run();

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@astrojs/compiler": patch
 +---
++
 +Fixes a bug caused by having an extra space in the fragment tag in the TSX output
Original file line number	Diff line number	Diff line change
@@ -706,10 +706,7 @@ declare const Astro: Readonly<import('astro').AstroGlobal<%s, typeof %s`, propsI
`706`	`706`	`}`
`707`	`707`	`}`
`708`	`708`	`if len(n.Attr) == 0 {`
`709`		`- endLoc = n.Loc[0].Start + len(n.Data) - 1`
`710`		`- }`
`711`		`- if endLoc == -1 {`
`712`		`- endLoc = 0`
	`709`	`+ endLoc = n.Loc[0].Start + len(n.Data)`
`713`	`710`	`}`
`714`	`711`	`isSelfClosing := false`
`715`	`712`	`hasLeadingSpace := false`