fix: stream Fragment sync siblings before async children resolve#16239
Merged
ematipico merged 4 commits intowithastro:mainfrom Apr 7, 2026
Merged
fix: stream Fragment sync siblings before async children resolve#16239ematipico merged 4 commits intowithastro:mainfrom
ematipico merged 4 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 063ca05 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Hi, @matthewp |
matthewp
approved these changes
Apr 7, 2026
ematipico
reviewed
Apr 7, 2026
ematipico
approved these changes
Apr 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
renderFragmentComponentwas callingrenderSlotToString, which eagerly awaited the entire slot content into a string before returning aRenderInstance. This caused sync siblings inside a<Fragment>to block until all async children resolved, unlike<div>and bare template expressions which streamed immediately.renderSlotToStringwithrenderSlot, so Fragment children go through the samerenderChild-> buffered async pipeline every other element uses.Testing
test/units/render/html-primitives.test.jsverifying sync content flushes to the destination before a deferred Promise resolves.test/streaming.test.jsusing a fixture page that mirrors the issue's exact reproduction — asserts sync content arrives in an earlier stream chunk than the async child.Docs
No docs change needed