fix: X-Forwarded-Proto rejected when allowedDomains includes protocol…#15594
Merged
louisescher merged 3 commits intowithastro:5-legacyfrom Feb 24, 2026
Merged
fix: X-Forwarded-Proto rejected when allowedDomains includes protocol…#15594louisescher merged 3 commits intowithastro:5-legacyfrom
louisescher merged 3 commits intowithastro:5-legacyfrom
Conversation
… and hostname (withastro#15560) The protocol validation in validateForwardedHeaders() passed the full pattern object to matchPattern(), which also checked hostname against the hardcoded test URL (example.com). Pass only { protocol } to matchPattern() so that only the protocol field is validated; the host+proto combination is already checked in the host validation block below. Fixes withastro#15559
🦋 Changeset detectedLatest commit: 93bd131 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Feb 20, 2026
Closed
1 task
This was referenced Feb 24, 2026
Merged
louisescher
approved these changes
Feb 24, 2026
Contributor
📊 Dependency Size ChangesWarning This PR adds 46.9 MB of new dependencies, which exceeds the threshold of 100 kB.
Total size change: 46.9 MB |
dadezzz
pushed a commit
to dadezzz/ice-notes
that referenced
this pull request
Mar 2, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.17.3` → `5.18.0`](https://renovatebot.com/diffs/npm/astro/5.17.3/5.18.0) |  |  | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v5.18.0`](https://github.com/withastro/astro/releases/tag/astro%405.18.0) [Compare Source](https://github.com/withastro/astro/compare/astro@5.17.3...astro@5.18.0) ##### Minor Changes - [#​15589](withastro/astro#15589) [`b7dd447`](withastro/astro@b7dd447) Thanks [@​qzio](https://github.com/qzio)! - Adds a new `security.actionBodySizeLimit` option to configure the maximum size of Astro Actions request bodies. This lets you increase the default 1 MB limit when your actions need to accept larger payloads. For example, actions that handle file uploads or large JSON payloads can now opt in to a higher limit. If you do not set this option, Astro continues to enforce the 1 MB default to help prevent abuse. ```js // astro.config.mjs export default defineConfig({ security: { actionBodySizeLimit: 10 * 1024 * 1024, // set to 10 MB }, }); ``` ##### Patch Changes - [#​15594](withastro/astro#15594) [`efae11c`](withastro/astro@efae11c) Thanks [@​qzio](https://github.com/qzio)! - Fix X-Forwarded-Proto validation when allowedDomains includes both protocol and hostname fields. The protocol check no longer fails due to hostname mismatch against the hardcoded test URL. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zMS45IiwidXBkYXRlZEluVmVyIjoiNDMuMzEuOSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <renovate@zarantonello.dev> Co-committed-by: Renovate Bot <renovate@zarantonello.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
backports #15560 to 5.x
Testing
Docs