Skip to content

Update vite#14621

Merged
florian-lefebvre merged 9 commits intowithastro:mainfrom
gameroman:update-vite
Oct 28, 2025
Merged

Update vite#14621
florian-lefebvre merged 9 commits intowithastro:mainfrom
gameroman:update-vite

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

@gameroman gameroman commented Oct 26, 2025

Changes

Bumped vite to 6.4.1

#14592
GHSA-93m4-6634-74q7

Testing

Existing tests in CI pass
No new tests required

Docs

No docs changes required

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 26, 2025

🦋 Changeset detected

Latest commit: 53567cd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 26, 2025
@ematipico
Copy link
Copy Markdown
Member

Thank you @gameroman

It's usually a good manner to keep the provided template, and fill the relevant sections. We don't ask much to avoid annoyance.

Do you think we need a changeset?

Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just unsure about the changeset

@gameroman
Copy link
Copy Markdown
Contributor Author

gameroman commented Oct 27, 2025

Thank you @gameroman

It's usually a good manner to keep the provided template, and fill the relevant sections. We don't ask much to avoid annoyance.

I did PR via editor interface, so there was no template, I've copied the template manually now

Do you think we need a changeset?

I don't know, maybe

@florian-lefebvre
Copy link
Copy Markdown
Member

In the past we've made changesets for these, eg. https://github.com/withastro/astro/pull/14326/files#diff-2961a69c42194c0091d1ea2606630c5d83a1d689e1fb4e8db85f022089290fbb. Would you mind adding one by running pnpm changeset locally and committing?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 28, 2025

📝 Changeset Validation Results

Changeset validation failed

Issues Found:

.changeset/twilight-shadows-dance.md

Issue with: 'Updates vite version to fix CVE'

❌ The description does not begin with a third-person singular present-tense verb. 'Updates' is correct, but the format requires the verb to clearly complete the sentence: 'This PR...'

💡 Consider revising the description to: markdown Fixes the `vite` version to address CVE vulnerabilities.


📖 See Astro's changeset guide for details.

Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florian-lefebvre florian-lefebvre merged commit e3175d9 into withastro:main Oct 28, 2025
20 of 21 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants