Remove warning for bun, causing unexpected console spam#14402
Conversation
🦋 Changeset detectedLatest commit: 7126211 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
cc @louisescher please take a look! |
CodSpeed Performance ReportMerging #14402 will not alter performanceComparing Summary
Footnotes |
|
Hi @FredKSchott. Sorry for this one. I believe this line was added fairly last minute before the PR got merged since we wanted to handle the bun case and not just show no versions, the side effect of it being shown while the dev server is running is obviously not intended. This is good to merge from my side. |
ascorbic
left a comment
There was a problem hiding this comment.
LGTM. The original reason was to avoid displaying nothing when used by Bun users, but I think they can live with it.
Changes
Fixes #14401
previously, Bun users were seeing this when they used
bunto install their npm packages, and then ranastro dev,astro build, etc.This was introduced in #14300 to intentionally add the message to
astro info, but not realizing that the helper functiongetInfoOutput()was called outside ofastro infoduring normal render, for debugging purposes.This PR removes that warning for now, since we shouldn't be printing inside of a helper utility like that. We could add it back in the future, but
I also don't think it's communicating the correct message about our Bun support (tldr: we support Node, and Bun is Node compatible, so Astro should be expected to work correctly in Bun. if it does not, that's bun's problem to solve, but that is different from "Bun is not supported").Update: wait I was wrong, this is Bun the package installer, not the runtime. AFAIK Astro runs for users who use Bun as their package installer, so I think this message is just wrong vs. not worded correctly. Please correct me if I'm incorrect on that, but we have many Astro users who usebunto install their packages so I can't imagine this is true.Testing
Not tested, just removed a console log.
Docs
Not needed.