feat: Add Vite version & integration versions to astro info#14300
feat: Add Vite version & integration versions to astro info#14300ematipico merged 40 commits intowithastro:mainfrom louisescher:feat/more-info-for-info
astro info#14300Conversation
🦋 Changeset detectedLatest commit: b1b7905 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14300 will not alter performanceComparing Summary
Footnotes |
for non-existent package.json files
|
@louisescher can you please show us a snapshot of the result? |
Fryuni
left a comment
There was a problem hiding this comment.
Forgot to mark as request changes. My bad.
This is what is now output by the I'll see what I can do about the requests by Luiz and then post another snapshot in here once that's ready. |
|
@ematipico For context, since pnpm uses a link for workspace packages, I was unable to properly resolve them. They thus show up as local, which I think makes sense. Edit: No clue why tests are failing. Seems to just be a timeout issue. |
Fryuni
left a comment
There was a problem hiding this comment.
I still think it would be best to show all installed versions of Astro, but for the intended scope of the PR this is fine. Just sent some small fixes/simplifications
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
|
Seen and applied, thank you. Just wondering what to do about tests now. I'm a bit out of my depth here, since just simply testing the CLI output that is tested currently doesn't really suffice anymore? Plus, testing with |
|
(merged main at Lou's request) |
Fryuni
left a comment
There was a problem hiding this comment.
Seems good. With everything passing this is a yes from me :)
…her/astro into feat/more-info-for-info
…' of https://github.com/louisescher/astro into feat/more-info-for-info
Here's what will be shown as the new output (for example)! |
ematipico
left a comment
There was a problem hiding this comment.
All good! I would handle the bun case. We shouldn't do anything fancy since we don't officially support it, but handling it safely should help
Changes
This PR adds information about the versions of Vite and the installed integrations when running
astro info. It does so by modifying the currentinfocommand and resolving thepackage.jsonfiles of both Astro and the integrations using thecreateRequirefunction.In cases where the name of the integration does not match the package's name, no version information is displayed.
Testing
A new test was added to check whether the correct version of Vite is displayed.
Docs
The output on https://docs.astro.build/en/reference/cli-reference/#astro-info is now (even more) outdated.