Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
- Coverage 37.16% 35.86% -1.31%
==========================================
Files 176 170 -6
Lines 40861 39341 -1520
==========================================
- Hits 15187 14109 -1078
+ Misses 25250 24645 -605
- Partials 424 587 +163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR creates a new separate GraphQL project by extracting GraphQL functionality from the main WireMock.Net project into a dedicated WireMock.Net.GraphQL assembly. This modularization allows the GraphQL functionality to be an optional dependency rather than being bundled with the core library.
- Extracted GraphQL-related classes and interfaces into a new WireMock.Net.GraphQL project
- Replaced direct GraphQL.Types.ISchema usage with a new ISchemaData abstraction
- Refactored GraphQL functionality to use dynamic loading through TypeLoader pattern
Reviewed Changes
Copilot reviewed 32 out of 39 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/WireMock.Net.GraphQL/ | New GraphQL project with matchers, models, and extension methods |
| src/WireMock.Net.Shared/ | Added TypeLoader utility and IGraphQLMatcher interface |
| src/WireMock.Net.Minimal/ | Updated serialization and removed embedded GraphQL functionality |
| test/ | Updated test references to use new GraphQL interfaces and namespaces |
Comments suppressed due to low confidence (2)
src/WireMock.Net.Minimal/Util/TypeLoader.cs:13
- The class name 'TypeLoader2' is unclear and suggests this is a temporary or duplicate implementation. Consider using a more descriptive name that indicates its purpose or relationship to the original TypeLoader.
internal static class TypeLoader2
src/WireMock.Net.Shared/Util/TypeLoader.cs:15
- The variable name 'Assemblies' is misleading as it stores Type objects, not Assembly objects. Consider renaming to 'TypeCache' or 'CachedTypes' to better reflect its contents.
private static readonly ConcurrentDictionary<string, Type> Assemblies = new();
This was referenced Aug 11, 2025
This was referenced Aug 18, 2025
This was referenced Sep 25, 2025
This was referenced Oct 6, 2025
This was referenced Oct 27, 2025
This was referenced Dec 8, 2025
This was referenced Dec 29, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.