Fix incorrect required_ruby_version#985
Merged
iliabylich merged 1 commit intowhitequark:masterfrom Jan 6, 2024
Merged
Conversation
This gem has used String#delete_suffix which was introduced at Ruby 2.5. https://github.com/whitequark/parser/blob/95d26953ebe823211845fb84cb93c18cd501f561/lib/parser/lexer/literal.rb#L250 Ref. https://github.com/ruby/ruby/blob/ruby_2_5/NEWS So, even Ruby 2.0 can be installed now, however it will not work.
Collaborator
|
Thanks! |
koic
added a commit
to koic/parser
that referenced
this pull request
Jan 6, 2024
This is an alternative approach to the changes in whitequark#985. The Parser gem may be required to operate across as many Ruby versions as possible. The use of `delete_suffix` starts from Parser version 3.3.0.0. Therefore, by replacing `delete_suffix` with `sub`, and releasing Parser 3.3.0.1, supporting Ruby 2.0 would be feasible.
iliabylich
pushed a commit
that referenced
this pull request
Jan 6, 2024
This is an alternative approach to the changes in #985. The Parser gem may be required to operate across as many Ruby versions as possible. The use of `delete_suffix` starts from Parser version 3.3.0.0. Therefore, by replacing `delete_suffix` with `sub`, and releasing Parser 3.3.0.1, supporting Ruby 2.0 would be feasible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gem has used String#delete_suffix which was introduced at Ruby 2.5.
parser/lib/parser/lexer/literal.rb
Line 250 in 95d2695
Ref. https://github.com/ruby/ruby/blob/ruby_2_5/NEWS
So, even Ruby 2.0 can be installed now, however it will not work.