Merged
Conversation
Collaborator
|
LGTM, thanks! We can ignore JRuby failure, I'll update the matrix myself. Do you need a release? |
Contributor
Author
|
Wow, so fast, thanks! No need to break out of your usual schedule, we can carry the patch for now ;) |
Collaborator
|
@nc7s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bacon saw its last code change in 2017, and an official announcement that development "halted". This replaces it with the actively maintained RSpec.
The motivation is Canop/bacon#342, ruby-ast is one of two packages still actively using bacon (the Ruby one).
The meat is migrating from the old
value.should.be/equal/etc. expectedsyntax to the newexpect(value).to/to_not eq/be/etc. expectedone.s()is somehow prohibited to run initblocks, socontextblocks are introduced to store them. Thehave_sexpthing which is basicallyvalue.should lambdaseems to have no equivalent in current RSpec, so I modified it a little to beexpect(lambda(<<-EOF).call(value)).to be true.All tests (now specs?) still pass.
RSpec has built-in color support, supposedly equivalent to bacon-colored_output.
I'm sorry the directory move from test/ to spec/ caused a full deletion and a long addition. In my Debian patch an option is added to the Rakefile block so it still uses the test/ directory, reducing patch size. If you'd like this to be that way, let me know.