fix: handle undefined bytes.buffer in createCursor for React Native#4164
Merged
fix: handle undefined bytes.buffer in createCursor for React Native#4164
Conversation
Fixes #4002 In React Native with the buffer polyfill, Uint8Array.buffer can be undefined. Added nullish coalescing fallback to use bytes directly if buffer is undefined.
🦋 Changeset detectedLatest commit: f3f295a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4164 +/- ##
==========================================
- Coverage 94.23% 94.20% -0.03%
==========================================
Files 1088 1088
Lines 8010 8011 +1
Branches 2567 2568 +1
==========================================
- Hits 7548 7547 -1
Misses 166 166
- Partials 296 298 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4002
In React Native with the
bufferpolyfill,Uint8Array.buffercan beundefined, causing aTypeError: Cannot read property 'buffer' of undefinedwhencreateCursorattempts to create aDataView.Added a nullish coalescing fallback (
bytes.buffer ?? bytes) so that ifbytes.bufferis undefined, it falls back to usingbytesdirectly as theArrayBuffer-like source for theDataView.