Detect coverage provider from bare vitest --coverage flag#1800
Merged
Conversation
commit: |
A bare `--coverage` enables coverage with the provider from the config (`test.coverage.provider`, default v8), which the args resolver can't see. Referencing `@vitest/coverage-v8` unconditionally there reports a false unlisted/unused dependency when another provider (e.g. istanbul) is configured. Reference the default v8 as an optional dependency instead, and leave an explicit `--coverage.provider=x` as a required reference; the config resolver already handles configured providers.
fc144da to
e34aacf
Compare
Member
|
Thanks for the PR. Tweaked it a bit, hope you don't mind :) |
Member
|
🚀 This pull request is included in v6.17.2. See Release 6.17.2 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vitest/coverage-v8reported as unused withvitest --coverage#1799Description
The Vitest plugin didn't recognize
@vitest/coverage-*as used when coverage was enabled via the bare--coverageflag (e.g."test": "vitest run --coverage"). The arg resolver only handled the provider as an object (--coverage.provider=v8):For a plain
--coverage,parsed.coverageistrue, so it was skipped and@vitest/coverage-v8was wrongly reported as an unused devDependency.Fix
Detect
@vitest/coverage-v8whenvitest --coverageis provided.