Don't disable configuration hints in workspace-scoped runs#1791
Merged
Conversation
commit: |
d0df127 to
b90b4c4
Compare
Member
|
Thanks for the PR. I deliberately gated this, because it might lead to confusion as ancestor + dependent workspaces of the selected ones are also included. Made an adjustment to your branch to resolve conflict and |
Contributor
|
Thanks for the adjustment. Since the common CI use case in monorepos is checking individual package/service workspaces, excluding root/top-level hints from workspace-scoped runs makes sense to me! |
Member
|
Thanks for the feedback, glad you agree. Let's go 🚀 |
Member
|
🚀 This pull request is included in v6.17.2. See Release 6.17.2 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--workspaceunconditionally disables configuration hints:So
--treat-config-hints-as-errorsis a silent no-op in workspace-scoped runs — in monorepo CI that lints only changed workspaces, staleignoreDependenciesentries can never fail CI.This PR filters hints to the selected workspaces instead of disabling them, mirroring how issues are filtered. Hints without a
workspaceNameare treated as root workspace hints.--no-config-hintsand production mode are unchanged. Tests added intest/workspaces/config-hints.test.ts.