Avoid caching failed plugin config loads#1768
Merged
webpro merged 2 commits intoMay 28, 2026
Merged
Conversation
commit: |
Member
|
Thanks Jake! Tested locally and pushed a fix on top. |
Member
|
🚀 This pull request is included in v6.15.0. See Release 6.15.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveConfigloading throws--cacheruns instead of masking the errorValidation
pnpm --dir packages/knip buildbun test test/plugin-config-load-error.test.tsfrompackages/knippnpm --dir packages/knip lintpnpm --dir packages/knip test --smokerm -rf ./node_modules/.cache/knip && node /Users/jakeleventhal/.codex/worktrees/f505/knip/packages/knip/dist/cli.js --no-progress --cache, then reran the same patched CLI with warm cache; both runs reported theapps/artelo/sls-api/serverless.tsandpackages/artelo/integrations/src/codegen.tsload errors instead of the warm cache passing silently.