Add openapi-ts plugin#1579
Conversation
commit: |
|
Boom 💯 |
|
@jonahsnider @webpro what does this plugin do? Are you knipping unused generated symbols? |
|
| "@hey-api/openapi-ts": "*" | ||
| }, | ||
| "dependencies": { | ||
| "@hey-api/typescript": "*", |
There was a problem hiding this comment.
@jonahsnider thanks! The only other thing I don't get are these dependencies. None of those @hey-api/* packages are published to npm, so I'd assume this is not needed unless it's something Knip-related
There was a problem hiding this comment.
Ah okay, good callout. This is definitely just a weird choice by Claude, but the logic here should be sound in terms of resolving plugin dependencies mentioned in the openapi-ts.config.ts
Missed this the first time around. I can make a follow-up PR to clear up the fixtures if that'd be desired? cc @webpro
There was a problem hiding this comment.
First time I see this too! @hey-api/openapi-ts is all you need for the foreseeable future, the plugins are bundled inside so no extra dependencies
There was a problem hiding this comment.
Name of the packages doesn't matter technically for Knip (just needs to match up). Feel free to fix it up to avoid potential confusion.
Please do PR if any listed plugin should not be listed in package.json, e.g. if it's built-in. Transitive dependencies of @hey-api/openapi-ts should not be flagged by Knip. Peer deeps should.
There was a problem hiding this comment.
Opened #1591 to make the test fixtures less confusing
|
🚀 This pull request is included in v5.86.0. See Release 5.86.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Add an openapi-ts plugin, so that
openapi-ts.config.tsis recognized as an entrypoint automatically