Fix wrangler plugin not enabled by jsonc config#1564
Merged
webpro merged 1 commit intowebpro-nl:mainfrom Feb 23, 2026
Merged
Conversation
commit: |
Member
|
Thanks Dániel! JSONC should cause no issues. And good to see you again ✨ |
Member
|
🚀 This pull request is included in v5.86.0. See Release 5.86.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋,
Last time when I added the wrangler plugin, json support wasn't stable yet, and only supported .json. Shortly after that, they released official json support, including .jsonc files, which is also the recommended format for new projects. Docs: https://developers.cloudflare.com/workers/wrangler/configuration/
This PR just adds jsonc into the supported file formats, so it's picked up as a config file. I tested it by converting the fixture's wrangler.toml into wrangler.jsonc, and it was picked up and main file was detected fine (biome made some changes in other plugins but I don't want to edit those in this PR)