Resolve _partial.scss in compiler (close #1439)

webpro · webpro · commit ee09aa339763 · 2026-01-08T18:52:31.000+01:00
diff --git a/packages/knip/src/compilers/scss.ts b/packages/knip/src/compilers/scss.ts
@@ -1,24 +1,27 @@
-import type { HasDependency } from './types.js';
+import { existsSync } from 'node:fs';
+import { basename, dirname, join } from '../util/path.js';
+import type { HasDependency, SyncCompilerFn } from './types.js';
 
 const condition = (hasDependency: HasDependency) =>
   hasDependency('sass') || hasDependency('sass-embedded') || hasDependency('node-sass');
 
 const importMatcher = /@(?:use|import|forward)\s+['"](pkg:)?([^'"]+)['"]/g;
 
-const toRelative = (specifier: string) => (specifier.startsWith('.') ? specifier : `./${specifier}`);
-
-const compiler = (text: string) => {
-  const imports = [];
-  let match: RegExpExecArray | null;
-  let index = 0;
-
-  // biome-ignore lint/suspicious/noAssignInExpressions: standard regex loop pattern
-  while ((match = importMatcher.exec(text))) {
-    if (match[2] && !match[2].startsWith('sass:'))
-      imports.push(`import _$${index++} from '${match[1] ? match[2] : toRelative(match[2])}';`);
-  }
-
-  return imports.join('\n');
+// Resolve _partials here to not soil the main resolver
+const resolvePartial = (specifier: string, containingFile: string) => {
+  const rel = specifier.startsWith('.') ? specifier : `./${specifier}`;
+  const name = basename(rel);
+  if (name.startsWith('_')) return rel;
+  const dir = dirname(rel);
+  const partial = name.endsWith('.scss') ? `_${name}` : `_${name}.scss`;
+  if (existsSync(join(dirname(containingFile), dir, partial))) return `${dir}/_${name}`;
+  return rel;
 };
 
+const compiler: SyncCompilerFn = (text, filePath) =>
+  [...text.matchAll(importMatcher)]
+    .filter(match => match[2] && !match[2].startsWith('sass:'))
+    .map((match, i) => `import _$${i} from '${match[1] ? match[2] : resolvePartial(match[2], filePath)}';`)
+    .join('\n');
+
 export default { condition, compiler };
diff --git a/packages/knip/test/compilers.scss.test.ts b/packages/knip/test/compilers.scss.test.ts
@@ -13,14 +13,11 @@ test('Built-in compiler for SCSS', async () => {
   const { issues, counters } = await main(options);
 
   assert(issues.files.has(join(cwd, 'unused.scss')));
-  assert(issues.files.has(join(cwd, '_partial.scss')));
-  assert(issues.unresolved['styles.scss']['./partial']);
 
   assert.deepEqual(counters, {
     ...baseCounters,
     devDependencies: 1,
-    files: 2,
-    unresolved: 1,
+    files: 1,
     processed: 14,
     total: 14,
   });
