Add support for git worktree (resolve #990, close #991)

webpro · webpro · commit b7bf92abd17c · 2025-12-27T10:15:02.000+01:00
diff --git a/packages/knip/fixtures/plugins/lefthook-v1/_git/HEAD b/packages/knip/fixtures/plugins/lefthook-v1/_git/HEAD
@@ -0,0 +1 @@
+ref: refs/heads/main
diff --git a/packages/knip/fixtures/plugins/lefthook-v1/_git/config b/packages/knip/fixtures/plugins/lefthook-v1/_git/config
@@ -0,0 +1,4 @@
+[core]
+	repositoryformatversion = 0
+	filemode = true
+	bare = false
diff --git a/packages/knip/src/WorkspaceWorker.ts b/packages/knip/src/WorkspaceWorker.ts
@@ -10,6 +10,7 @@ import type {
   GetInputsFromScriptsPartial,
   GetSourceFile,
   HandleInput,
+  Plugin,
   WorkspaceConfiguration,
 } from './types/config.js';
 import type { ConfigurationHint } from './types/issues.js';
@@ -186,13 +187,16 @@ export class WorkspaceWorker {
     return [patterns, this.negatedWorkspacePatterns].flat();
   }
 
+  private getPluginConfig(plugin: Plugin) {
+    return typeof plugin.config === 'function' ? plugin.config({ cwd: this.dir }) : plugin.config;
+  }
+
   getPluginConfigPatterns() {
     const patterns: string[] = [];
     for (const [pluginName, plugin] of PluginEntries) {
       const pluginConfig = this.getConfigForPlugin(pluginName);
       if (this.enabledPluginsMap[pluginName] && pluginConfig) {
-        const { config } = pluginConfig;
-        patterns.push(...(config ?? plugin.config ?? []));
+        patterns.push(...(pluginConfig.config ?? this.getPluginConfig(plugin) ?? []));
       }
     }
     return patterns;
@@ -234,7 +238,7 @@ export class WorkspaceWorker {
   private getConfigurationFilePatterns(pluginName: PluginName) {
     const plugin = Plugins[pluginName];
     const pluginConfig = this.getConfigForPlugin(pluginName);
-    return pluginConfig.config ?? plugin.config ?? [];
+    return pluginConfig.config ?? this.getPluginConfig(plugin) ?? [];
   }
 
   public async runPlugins() {
diff --git a/packages/knip/src/plugins/lefthook/index.ts b/packages/knip/src/plugins/lefthook/index.ts
@@ -13,10 +13,6 @@ const enablers = ['lefthook', '@arkweid/lefthook', '@evilmartians/lefthook'];
 
 const isEnabled: IsPluginEnabled = ({ dependencies }) => hasDependency(dependencies, enablers);
 
-const gitHookPaths = getGitHookPaths();
-
-const config = ['lefthook.yml', ...gitHookPaths];
-
 type Command = {
   run: string;
   root: string;
@@ -56,7 +52,7 @@ const plugin: Plugin = {
   title,
   enablers,
   isEnabled,
-  config,
+  config: options => ['lefthook.yml', ...getGitHookPaths('.git/hooks', true, options.cwd)],
   resolveConfig,
 };
 
diff --git a/packages/knip/src/types/config.ts b/packages/knip/src/types/config.ts
@@ -155,7 +155,7 @@ export interface Plugin {
   enablers?: IgnorePatterns | string;
   isEnabled?: IsPluginEnabled;
   isRootOnly?: boolean;
-  config?: string[];
+  config?: string[] | ((options: { cwd: string }) => string[]);
   entry?: string[];
   production?: string[];
   project?: string[];
diff --git a/packages/knip/src/util/git.ts b/packages/knip/src/util/git.ts
@@ -12,15 +12,19 @@ const hookFileNames = [
   'post-{checkout,commit,merge,rewrite}',
 ];
 
-const getGitHooksPath = (defaultPath = '.git/hooks') => {
+const getGitHooksPath = (defaultPath = '.git/hooks', cwd: string | undefined) => {
   try {
-    return execSync('git config --get core.hooksPath', { encoding: 'utf8', stdio: ['pipe', 'pipe', 'ignore'] }).trim();
+    return execSync('git rev-parse --git-path hooks', {
+      encoding: 'utf8',
+      stdio: ['pipe', 'pipe', 'ignore'],
+      cwd,
+    }).trim();
   } catch (_error) {
     return defaultPath;
   }
 };
 
-export const getGitHookPaths = (defaultPath = '.git/hooks', followGitConfig = true) => {
-  const gitHooksPath = followGitConfig ? getGitHooksPath(defaultPath) : defaultPath;
+export const getGitHookPaths = (defaultPath = '.git/hooks', followGitConfig = true, cwd?: string) => {
+  const gitHooksPath = followGitConfig ? getGitHooksPath(defaultPath, cwd) : defaultPath;
   return hookFileNames.map(fileName => join(gitHooksPath, fileName));
 };
