Fix false positive unused deps when run from workspace dir (resolve #1642)

webpro · webpro · commit 95f443195712 · 2026-03-26T09:03:40.000+01:00
diff --git a/packages/knip/src/graph/build.ts b/packages/knip/src/graph/build.ts
@@ -397,14 +397,16 @@ export async function build({
         if (!isIgnored) pp.addEntryPath(filePath, { skipExportsAnalysis: true });
       }
 
+      const wsDependencies = deputy.getDependencies(workspace.name);
       for (const _import of file.imports.imports) {
-        if (_import.filePath) {
-          const packageName = getPackageNameFromModuleSpecifier(_import.specifier);
-          if (packageName && isInternalWorkspace(packageName)) {
-            file.imports.external.add({ ..._import, specifier: packageName });
-            if (!isGitIgnored(_import.filePath)) {
-              pp.addProgramPath(_import.filePath);
-            }
+        if (!_import.filePath) continue;
+        const packageName = getPackageNameFromModuleSpecifier(_import.specifier);
+        if (!packageName) continue;
+        const isWorkspace = isInternalWorkspace(packageName);
+        if (isWorkspace || wsDependencies.has(packageName)) {
+          file.imports.external.add({ ..._import, specifier: packageName });
+          if (isWorkspace && !isGitIgnored(_import.filePath)) {
+            pp.addProgramPath(_import.filePath);
           }
         }
       }
diff --git a/packages/knip/test/workspaces-pnpm.test.ts b/packages/knip/test/workspaces-pnpm.test.ts
@@ -21,3 +21,10 @@ test('Find unused dependencies, exports and files in workspaces (loose)', async
     total: 4,
   });
 });
+
+test('Find no false unused workspace dependencies when run from workspace dir', async () => {
+  const options = await createOptions({ cwd: resolve('fixtures/workspaces-pnpm/apps/app-a') });
+  const { counters } = await main(options);
+
+  assert.equal(counters.dependencies, 0);
+});

Original file line number	Diff line number	Diff line change
`@@ -397,14 +397,16 @@ export async function build({`
`397`	`397`	`if (!isIgnored) pp.addEntryPath(filePath, { skipExportsAnalysis: true });`
`398`	`398`	`}`
`399`	`399`
	`400`	`+ const wsDependencies = deputy.getDependencies(workspace.name);`
`400`	`401`	`for (const _import of file.imports.imports) {`
`401`		`- if (_import.filePath) {`
`402`		`- const packageName = getPackageNameFromModuleSpecifier(_import.specifier);`
`403`		`- if (packageName && isInternalWorkspace(packageName)) {`
`404`		`- file.imports.external.add({ ..._import, specifier: packageName });`
`405`		`- if (!isGitIgnored(_import.filePath)) {`
`406`		`- pp.addProgramPath(_import.filePath);`
`407`		`- }`
	`402`	`+ if (!_import.filePath) continue;`
	`403`	`+ const packageName = getPackageNameFromModuleSpecifier(_import.specifier);`
	`404`	`+ if (!packageName) continue;`
	`405`	`+ const isWorkspace = isInternalWorkspace(packageName);`
	`406`	`+ if (isWorkspace \|\| wsDependencies.has(packageName)) {`
	`407`	`+ file.imports.external.add({ ..._import, specifier: packageName });`
	`408`	`+ if (isWorkspace && !isGitIgnored(_import.filePath)) {`
	`409`	`+ pp.addProgramPath(_import.filePath);`
`408`	`410`	`}`
`409`	`411`	`}`
`410`	`412`	`}`