Suppress issues initially to not overwhelm agent in mcp server

webpro · webpro · commit 7793962c56c6 · 2026-03-26T10:08:58.000+01:00
Often agent starts to fix issues instead of config hints
diff --git a/packages/mcp-server/src/texts.js b/packages/mcp-server/src/texts.js
@@ -56,6 +56,9 @@ export const ERROR_HINT = `For unexpected errors (exit code 2) such as "error lo
 - If no config file exists, create knip.json in the project root
 - Run knip again`;
 
+export const UNCONFIGURED_HINT =
+  'Issues are suppressed because the project is not yet configured. Reported issues might be false positives. Address configuration hints first, then re-run to get the actual issues.';
+
 export const CONFIG_REVIEW_HINT = `Review the existing configuration for potential improvements:
 
 - Never use "ignore" patterns (hides real issues!), always prefer specific solutions; other ignore* options are allowed
diff --git a/packages/mcp-server/src/tools.js b/packages/mcp-server/src/tools.js
@@ -3,7 +3,7 @@ import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { createOptions, createSession, finalizeConfigurationHints, KNIP_CONFIG_LOCATIONS } from 'knip/session';
 import { CURATED_RESOURCES } from './curated-resources.js';
-import { CONFIG_REVIEW_HINT } from './texts.js';
+import { CONFIG_REVIEW_HINT, UNCONFIGURED_HINT } from './texts.js';
 
 export { ERROR_HINT } from './texts.js';
 
@@ -30,15 +30,30 @@ const docsDir = join(__dirname, './docs');
  * @param {{ cwd: string, configFilePath: string | undefined }} options
  */
 export function buildResults(results, options) {
+  const configurationHints = finalizeConfigurationHints(results, options);
+
+  const isSuppressIssues =
+    results.counters.total >= 10 &&
+    configurationHints.some(hint => hint.type === 'top-level-unconfigured' || hint.type === 'workspace-unconfigured');
+
+  const configFile = options.configFilePath
+    ? { exists: true, filePath: options.configFilePath }
+    : { exists: false, locations: KNIP_CONFIG_LOCATIONS };
+
+  const reviewHint = isSuppressIssues ? UNCONFIGURED_HINT : options.configFilePath ? CONFIG_REVIEW_HINT : undefined;
+  const files = isSuppressIssues ? [] : Array.from(results.issues.files);
+  const issues = isSuppressIssues
+    ? []
+    : Object.fromEntries(Object.entries(results.issues).filter(([key]) => key !== 'files' && key !== '_files'));
+
   return {
-    configFile: options.configFilePath
-      ? { exists: true, filePath: options.configFilePath, reviewHint: CONFIG_REVIEW_HINT }
-      : { exists: false, locations: KNIP_CONFIG_LOCATIONS },
-    configurationHints: finalizeConfigurationHints(results, options),
+    reviewHint,
+    configFile,
+    configurationHints,
     counters: results.counters,
     enabledPlugins: results.enabledPlugins,
-    files: Array.from(results.issues.files),
-    issues: Object.fromEntries(Object.entries(results.issues).filter(([key]) => key !== 'files' && key !== '_files')),
+    files,
+    issues,
   };
 }
 
