Add followCursor setting for Imports/Exports views (resolve #1788)

webpro · webpro · commit 67a0be89fe34 · 2026-06-15T11:29:04.000+02:00
diff --git a/packages/vscode-knip/package.json b/packages/vscode-knip/package.json
@@ -287,6 +287,11 @@
             "type": "boolean",
             "default": true,
             "description": "Enable imports view"
+          },
+          "knip.imports.followCursor": {
+            "type": "boolean",
+            "default": true,
+            "description": "Reveal and select the import matching the editor cursor position. Disable to keep the view in sync without it taking focus, e.g. when moved out of the Explorer."
           }
         }
       },
@@ -302,6 +307,11 @@
             "default": true,
             "description": "Enable exports view"
           },
+          "knip.exports.followCursor": {
+            "type": "boolean",
+            "default": true,
+            "description": "Reveal and select the export matching the editor cursor position. Disable to keep the view in sync without it taking focus, e.g. when moved out of the Explorer."
+          },
           "knip.exports.contention.enabled": {
             "type": "boolean",
             "default": true,
diff --git a/packages/vscode-knip/src/tree-view-base.js b/packages/vscode-knip/src/tree-view-base.js
@@ -25,7 +25,9 @@ const isGlobLike = specifier => specifier.includes('*');
 
 /** @implements {vscode.TreeDataProvider<TreeViewItem>} */
 export class BaseTreeViewProvider {
-  constructor() {
+  /** @param {string} configSection */
+  constructor(configSection) {
+    this.configSection = configSection;
     this._onDidChangeTreeData = new vscode.EventEmitter();
     this.onDidChangeTreeData = this._onDidChangeTreeData.event;
     this.currentUri = undefined;
@@ -129,6 +131,7 @@ export class BaseTreeViewProvider {
   /** @param {vscode.Position} position */
   async revealItemAtCursor(position) {
     if (!this.file || !this.treeView) return;
+    if (!vscode.workspace.getConfiguration('knip').get(`${this.configSection}.followCursor`, true)) return;
 
     try {
       const items = this._rootItems ?? [];
diff --git a/packages/vscode-knip/src/tree-view-exports.js b/packages/vscode-knip/src/tree-view-exports.js
@@ -16,6 +16,10 @@ const CONTENTION_TOOLTIPS = {
  * @extends {BaseTreeViewProvider}
  */
 export class ExportsTreeViewProvider extends BaseTreeViewProvider {
+  constructor() {
+    super('exports');
+  }
+
   /** @param {import('knip/session').File} fileNode */
   getFileItems(fileNode) {
     const isDeferChildren = fileNode.exports.length > 9;
diff --git a/packages/vscode-knip/src/tree-view-imports.js b/packages/vscode-knip/src/tree-view-imports.js
@@ -6,6 +6,10 @@ import { BaseTreeViewProvider, toTree } from './tree-view-base.js';
  * @extends {BaseTreeViewProvider}
  */
 export class ImportsTreeViewProvider extends BaseTreeViewProvider {
+  constructor() {
+    super('imports');
+  }
+
   /** @param {import('knip/session').File} fileNode */
   getFileItems(fileNode) {
     if (fileNode.internalImports.length === 0) return [this.createMessageItem('(none)')];
