misc(dep): add webpack 4 as peer dependency#297
Merged
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
approved these changes
Mar 1, 2018
Contributor
|
Why a beta version has been added as peer dependency? |
Contributor
Author
Are there any features that came after beta which are required by cli? |
Member
|
This is correct, latest webpack should be the one we're targeting |
Contributor
|
Alpha and beta are releases that talks by themselves, they are still not officials. I think the package.json should state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Dependencies definition, Fixes #295
Summary
Adds webpack 4 as a peer dependency
Does this PR introduce a breaking change?
No
Other information
Followed same versioning as webpack-dev-server