Skip to content

misc(yargs): add description for module-bind-* args#286

Merged
evenstensberg merged 1 commit into
webpack:masterfrom
dhruvdutt:enhance/config-yargs
Feb 27, 2018
Merged

misc(yargs): add description for module-bind-* args#286
evenstensberg merged 1 commit into
webpack:masterfrom
dhruvdutt:enhance/config-yargs

Conversation

@dhruvdutt

@dhruvdutt dhruvdutt commented Feb 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
Enhancement

Summary
Add missing description for module-bind-post and module-bind-pre arguments

Docs link for the same.

Does this PR introduce a breaking change?
No

evenstensberg
evenstensberg reviewed Feb 26, 2018
View reviewed changes

@evenstensberg evenstensberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point to the documentation for this? Gotta double check

@dhruvdutt

dhruvdutt commented Feb 26, 2018

Copy link
Copy Markdown
Contributor Author

@ev1stensberg Updated the PR description. Here's the link again.

@evenstensberg

evenstensberg commented Feb 26, 2018

Copy link
Copy Markdown
Member

Can you rebase the commit to match the spec? We'll need a feat flag, but it hasn't been implemented yet

@dhruvdutt dhruvdutt force-pushed the enhance/config-yargs branch from 081722b to 2609f78 Compare February 26, 2018 20:41
@webpack-bot

webpack-bot commented Feb 26, 2018

Copy link
Copy Markdown

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@dhruvdutt dhruvdutt changed the title feat(yargs): add description for module-bind-* args misc(yargs): add description for module-bind-* args Feb 26, 2018
@dhruvdutt dhruvdutt force-pushed the enhance/config-yargs branch from 2609f78 to 2d2ccf3 Compare February 26, 2018 20:42
@webpack-bot

webpack-bot commented Feb 26, 2018

Copy link
Copy Markdown

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@dhruvdutt

dhruvdutt commented Feb 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ev1stensberg Sorry, I didn't get what you meant here.

We'll need a feat flag, but it hasn't been implemented yet

Where do we need to implement flag? Is it something related to cz-config.js?

@evenstensberg

evenstensberg commented Feb 27, 2018

Copy link
Copy Markdown
Member

Lgtm

@evenstensberg evenstensberg merged commit 191b458 into webpack:master Feb 27, 2018
@dhruvdutt

dhruvdutt commented Feb 27, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ev1stensberg Should I setup/implement feat flag inside cz-config.js?

I think we can just rename new_feature to feat.

@dhruvdutt dhruvdutt deleted the enhance/config-yargs branch February 27, 2018 18:33
@evenstensberg

evenstensberg commented Mar 1, 2018

Copy link
Copy Markdown
Member

yep, up for grabs. As well as a cli() thing for bin/webpack.js changes.

@dependabot-preview dependabot-preview Bot mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evenstensberg evenstensberg evenstensberg left review comments
+1 more reviewer
@ematipico ematipico ematipico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: CI-ok PR: review-outdated PR: small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhruvdutt @evenstensberg @webpack-bot @ematipico